Missing timeout check on ExecutorService.awaitTermination

Noncompliant example

  public void shutdownNonCompliant(ExecutorService executor) {
    executor.shutdown();
    try {
        // Noncompliant: awaitTermination might silently time out before all threads finish their execution.
        executor.awaitTermination(10, TimeUnit.SECONDS);
    } catch (InterruptedException e) {
        log.warn("Failed to wait for all tasks to finish", e);
    }
}

Compliant example

  public void shutdownCompliant(ExecutorService executor) {
    executor.shutdown();
    try {
        // Compliant: code handles the case when awaitTermination times out.
        if (!executor.awaitTermination(10, TimeUnit.SECONDS)) {
            log.warn("Failed to terminate executor");
        }
    } catch (InterruptedException e) {
        log.warn("Failed to wait for all tasks to finish", e);
    }
}